Fixes being unable to re-enter your body when you're unnested #3747
Conversation
There was a problem hiding this comment.
Code works, though please also consider changing the ghost prompt in /mob/living/proc/do_ghost() when you remain in body for the first prompt. (As in get nested > remain > ghost)
It looks like this currently:
And if you changed it to say text_prompt += "\nSince you're nested, you will get a chance to reenter your body if freed." it would look like this:
That’s a bug with the tgui prompt. It should scale according to contents. Out of scope |
|
You are altering the action of ghosting when nested. That is the prompt given to users when doing that action; so it is not out of scope. Sure updating tgui_alert to adapt to the size isn't very related; but thats not what I requested. The message is needlessly wordy regardless. |
I’m not altering anything about ghosting. I’m only touching nest unbuckling |
|
I'll take the GBP for the requested change in a separate PR then. |
# About the pull request This PR is a followup to #3597 that was requested but refused in #3747 to improve the situation where there is too much text in a tgui_alert when ghosting while nested. # Explain why it's good for the game Instead of:  It is now:  # Testing Photographs and Procedure 1. Get nested 2. Remain in body for the first prompt 3. Ghost # Changelog :cl: Drathek spellcheck: Tweaked message when ghosting while nested /:cl:
About the pull request
Turns out the parent call of unbuckle() calls afterbuckle() which deletes the nest and clears ghost_of_buckled_mob, which means it can't set your ghost to can_reenter_corpse = TRUE
Explain why it's good for the game
Bugs bad
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: You can now re-enter your body when unnested, marine mains, rejoice!
/:cl: